Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44939 )
Change subject: mb/google/dedede/var/drawcia: Add MIPI camera support
......................................................................
Patch Set 13:
(2 comments)
Patch Set 1:
Patch Set 1:
@Chen,@Shawn,
Can you have take the following as reference and move this ti SSDT?
CB:41758
CB:44397
CB:42205
Reply on behave of Intel Shawn. Some of the CLs are not merged yet. Suggest to adopt SSDT to Drawcia camera config after the the new CB arch is reviewed/merged. If Quanta is urgent, suggest they can cherrypick this DSDT CL for factory build and verification.
https://review.coreboot.org/c/coreboot/+/44939/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44939/8//COMMIT_MSG@10
PS8, Line 10: 2. add IPU/VCM/NVM/CAM1 in devicetree
Can you please mention it is WFC. I interpret it so, but is not clear.
Done
https://review.coreboot.org/c/coreboot/+/44939/8//COMMIT_MSG@13
PS8, Line 13: grap
Nit: grap -> grab
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96f2ef682dff851d7788c2b612765a92228ddf75
Gerrit-Change-Number: 44939
Gerrit-PatchSet: 13
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: Tomasz Figa
tfiga@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Yeh
andy.yeh@intel.com
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Matt Delco
delco@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 22 Oct 2020 07:41:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment