27 May
2019
27 May
'19
10:38 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33017 )
Change subject: mb/google/poppy/variants/nami: Disable FPMCU for non-fingerprint variants ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33017/3/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nami/mainboard.c:
https://review.coreboot.org/#/c/33017/3/src/mainboard/google/poppy/variants/... PS3, Line 264: spi_fpmcu->enabled = 0; Is this really true for all the different SKUs above?
--
To view, visit https://review.coreboot.org/c/coreboot/+/33017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6fa96e04a34e296889414b96a8c604fc61b8a236
Gerrit-Change-Number: 33017
Gerrit-PatchSet: 3
Gerrit-Owner: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 27 May 2019 22:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment