build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33049 )
Change subject: drivers/intel/fsp1_1: Exit cleanly if FSP not found
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33049/3/src/drivers/intel/fsp1_1/car.c
File src/drivers/intel/fsp1_1/car.c:
https://review.coreboot.org/#/c/33049/3/src/drivers/intel/fsp1_1/car.c@166
PS3, Line 166: die_with_post_code(POST_INVALID_CBFS, "Unable to locate fsp.bin");
line over 80 characters
https://review.coreboot.org/#/c/33049/3/src/drivers/intel/fsp1_1/car.c@170
PS3, Line 170: FSP_INFO_HEADER *fih = find_fsp((uintptr_t)rdev_mmap_full(prog_rdev(&fsp)));
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33049
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I761e7febc7cec5bd2ef3af214bc51777ee5c313d
Gerrit-Change-Number: 33049
Gerrit-PatchSet: 3
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 May 2019 16:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment