build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47380 )
Change subject: mb/google/kukui: Add panel api after dsi start ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 101: if (panel->post_power_on) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 101: if (panel->post_power_on) suspect code indent for conditional statements (7, 15)
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 102: panel->post_power_on(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 102: panel->post_power_on(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_anx7625.c:
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 38: * so we should do nothing here. code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 39: */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 47: printk(BIOS_ERR, "start display start_anx7625\n"); Prefer using '"%s...", __func__' to using 'start_anx7625', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 55: .power_on = dummy_power_on, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/47380/1/src/mainboard/google/kukui/... PS1, Line 56: .post_power_on = start_anx7625, please, no spaces at the start of a line