[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add pcie root complex driver

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add pcie root complex driver
......................................................................

Patch Set 32:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
PS31, Line 41: for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
> This looks much better. […]

I agree. I filed b/156946266 to understand what the 12MB before TOM is. We also need to figure out https://chrome-internal-review.googlesource.com/c/chromeos/third_party/amd-f.... Once those two are solved, I think we can comeback and revisit this code and clean it up.