Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/26833
Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI ......................................................................
g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
GMCH_HDMI_MODE_SELECT_HDMI does not seem to work on all displays.
Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M common/g45/hw-gfx-gma-gmch-hdmi.adb 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/33/26833/1
diff --git a/common/g45/hw-gfx-gma-gmch-hdmi.adb b/common/g45/hw-gfx-gma-gmch-hdmi.adb index 4c84f36..20df5b2 100644 --- a/common/g45/hw-gfx-gma-gmch-hdmi.adb +++ b/common/g45/hw-gfx-gma-gmch-hdmi.adb @@ -59,14 +59,16 @@ GMCH_HDMI_VSYNC_ACTIVE_HIGH else 0); begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); - + -- TODO: GMCH_HDMI_MODE_SELECT_HDMI does not seem to work on all panels. + -- Should this be detected or is GMCH_HMDI_MODE_SELECT_DVI fine in all + -- case? Registers.Unset_And_Set_Mask (Register => GMCH_HDMI (Port_Cfg.Port), Mask_Unset => GMCH_HDMI_MASK, Mask_Set => GMCH_HDMI_ENABLE or GMCH_PORT_PIPE_SELECT (Pipe) or GMCH_HDMI_SDVO_ENCODING_HDMI or - GMCH_HDMI_MODE_SELECT_HDMI or + GMCH_HDMI_MODE_SELECT_DVI or Polarity); end On;