build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40785 )
Change subject: soc/amd/hda: Move HDA PCI device from DSDT to SSDT ......................................................................
Patch Set 1:
(9 comments)
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... File src/soc/amd/stoneyridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 525: * Offset (0x42), please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 526: * NSDI, 1, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 527: * NSDO, 1, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 528: * NSEN, 1, please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 537: * If (LEqual (OSVR, 0x03)) { please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 538: * Store (Zero, NSEN) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 539: * Store (One, NSDO) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 540: * Store (One, NSDI) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40785/1/src/soc/amd/stoneyridge/nor... PS1, Line 541: * } please, no space before tabs