Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48642 )
Change subject: zork: update gumboz variant
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48642/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/gumboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/48642/2/src/mainboard/google/zork/v...
PS2, Line 17: K4AAG165WA-BCWE, 10
moreover, since the board design is almost the same to dirinboz except the convertible sensor and di […]
This is going to make the firmware support really difficult for shipping devices for gumboz. We should not be allocating fixed IDs since it unnecessarily uses up the ID space and does not optimize for the parts that can share the same SPD. Can you please add details on the bug about when the build happened and what DRAM parts were used for the build?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80c03d531761c02b68bd127d889c3ace2dd9e99e
Gerrit-Change-Number: 48642
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Dec 2020 18:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu
kevin.chiu.17802@gmail.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment