Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )
Change subject: drivers/wifi: Add generic WiFi driver ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33155/4/src/drivers/intel/wifi/chip... File src/drivers/intel/wifi/chip.h:
https://review.coreboot.org/c/coreboot/+/33155/4/src/drivers/intel/wifi/chip... PS4, Line 19: #include "drivers/wifi/generic_wifi.h"
Sure will remove it.
Done
https://review.coreboot.org/c/coreboot/+/33155/4/src/drivers/wifi/generic.c File src/drivers/wifi/generic.c:
https://review.coreboot.org/c/coreboot/+/33155/4/src/drivers/wifi/generic.c@... PS4, Line 230: const char *generic_wifi_acpi_name(const struct device *dev)
It would be a violation only if the same name appears under the same namescope and path. […]
Done