[coreboot-gerrit] Change in ...coreboot[master]: mediatek/mt8183: fix mode register setting fail issue

[You-Cheng Syu (Code Review)]

You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32284 )

Change subject: mediatek/mt8183: fix mode register setting fail issue
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32284/4/src/soc/mediatek/mt8183/dramc_init_s... 
File src/soc/mediatek/mt8183/dramc_init_setting.c:

https://review.coreboot.org/#/c/32284/4/src/soc/mediatek/mt8183/dramc_init_s... 
PS4, Line 21: #include <delay.h>
sort the include lines

https://review.coreboot.org/#/c/32284/4/src/soc/mediatek/mt8183/dramc_init_s... 
PS4, Line 668: dramc_mode_reg_init_sequence
This array should be mark as 'static' if it won't be access from any other file.
(So should dramc_init_sequence)