Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/c_start.S
File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/c_start.S@42
PS2, Line 42: _start:
Sorry, I meant a weak symbol that calls the code in exit_car. […]
got it, i can try something like and see
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/exit_car.S
File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/34752/2/src/arch/x86/exit_car.S@48
PS2, Line 48: post_car_stack_top
The stackpointer is moved here and at L76 in c_start.S "movl $_estack, %esp". […]
i don't think we are selecting CONFIG_SOC_SETS_MSRS ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc88e6727b2fa692585dffe576e69f6d4d0b349d
Gerrit-Change-Number: 34752
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 10:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment