Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34130 )
Change subject: soc/intel/cannonlake: Enable FSP to use coreboot stack ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
Is this tested on CFL, CNL, WHL and CML? What happens if you use a FSP2.0 binary with this?
This is tested on CML platforms, if we don't enable the config with v1263(start of shared stack support(FSP 2.1 feature)), we see hang in memory init call, where is fails to call a mem init API due to stack constraints.
https://review.coreboot.org/c/coreboot/+/34130/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34130/1//COMMIT_MSG@9 PS1, Line 9: v1263
Can you explain this versioning scheme to me? The FSP on Github uses […]
the 1 here is the year project started(1 is same year as it started), 26 is the work week(now is WW 28) and 3 is the day within the week so 3 is wednesday. That is when the label was created. On the external availability, I am not sure on the timelines