Attention is currently required from: Angel Pons, Kyösti Mälkki, Patrick Rudolph.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61517 )
Change subject: [WIP]aopen/dxplplusu: Enable SMM_ASEG
......................................................................
Patch Set 3:
(1 comment)
File src/southbridge/intel/i82801dx/smihandler.c:
https://review.coreboot.org/c/coreboot/+/61517/comment/bd39ea44_8d2fac70
PS3, Line 35: reg16 = inw(pmbase + PM1_STS);
: /* set status bits are cleared by writing 1 to them */
: outw(reg16, pmbase
maybe {read,write}_pmbaseXX (src/southbridge/intel/common/pmbase.c)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If20a7092117612a1a9e25eb6ac480e105acd57d7
Gerrit-Change-Number: 61517
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 08 Nov 2022 16:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment