Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27369 )
Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT
......................................................................
Patch Set 46: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/27369/46//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/27369/46//COMMIT_MSG@36
PS46, Line 36: current slot MCU and RW staging MCU are same. If so, update the staging area
why do you need to update the staging area if it's the same microcode?
https://review.coreboot.org/c/coreboot/+/27369/46//COMMIT_MSG@39
PS46, Line 39: Also, make sure that the top is enabled in normal/developer mode and disabled
top swap?
https://review.coreboot.org/c/coreboot/+/27369/46/src/soc/intel/common/basec...
File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/c/coreboot/+/27369/46/src/soc/intel/common/basec...
PS46, Line 33: __weak void ucode_update_reboot(void)
I don't see the need for weak here
https://review.coreboot.org/c/coreboot/+/27369/46/src/soc/intel/common/basec...
PS46, Line 143: /* Get slot MCU */
why is it called slot?
Isn't it a file in CBFS?
https://review.coreboot.org/c/coreboot/+/27369/46/src/soc/intel/common/basec...
PS46, Line 160: /* Compare */
that's clear by memcmp. What do you compare?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27369
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655
Gerrit-Change-Number: 27369
Gerrit-PatchSet: 46
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Dhaval Sharma
dhaval.v.sharma@intel.corp-partner.google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: rushikesh s kadam
rushikesh.s.kadam@intel.com
Gerrit-Comment-Date: Thu, 19 Sep 2019 06:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment