Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39004 )
Change subject: drivers: Replace set_vbe_mode_info_valid
......................................................................
Patch Set 31:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39004/30/src/soc/nvidia/tegra124/di...
File src/soc/nvidia/tegra124/display.c:
https://review.coreboot.org/c/coreboot/+/39004/30/src/soc/nvidia/tegra124/di...
PS30, Line 316: struct edid edid;
: edid.mode.va = config->yres;
: edid.mode.ha = config->xres;
: edid_set_framebuffer_bits_per_pixel(&edid,
: config->framebuffer_bits_per_pixel, 32);
: fb_new_framebuffer_info_from_edid(&edid, (uintptr_t)(framebuffer_base_mb*MiB));
This looks like another case for fb_add_framebuffer_info().
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95d1d62385a201c68c6c2527c023ad2292a235c5
Gerrit-Change-Number: 39004
Gerrit-PatchSet: 31
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 08:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment