[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: add UPD for USB3 phy setting adjust

[chris wang (Code Review)]

Attention is currently required from: Martin Roth, Felix Held.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )

Change subject: soc/amd/picasso: add UPD for USB3 phy setting adjust
......................................................................

Patch Set 8:

(3 comments)

File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/50240/comment/a28b4119_82148bd0 
PS7, Line 258: usb3_phy_en
> usb3_phy_override would be a much more descriptive name. […]

Done

https://review.coreboot.org/c/coreboot/+/50240/comment/35aa97c3_2b09f7de 
PS7, Line 258: 	uint8_t usb3_phy_en;
> Yes, I add the default value in the tremyle and delboz's devtree, but agree with you that to have a  […]

Done

File src/vendorcode/amd/fsp/picasso/FspsUpd.h:

https://review.coreboot.org/c/coreboot/+/50240/comment/8d28addf_875833c2 
PS7, Line 58: /** Offset 0x013D**/	uint8_t                     usb_3_port0_phy_tune[2];
            : 	/** Offset 0x013F**/	uint8_t                     usb_3_port1_phy_tune[2];
            : 	/** Offset 0x0141**/	uint8_t                     usb_3_port2_phy_tune[2];
            : 	/** Offset 0x0143**/	uint8_t                     usb_3_port3_phy_tune[2];
> Sure, so that need have a define like FSPS_UPD_USB2_PORT_COUNT. I will check that.

Done