Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52475 )
Change subject: mb/hp: Add Compal LA-A992P ......................................................................
Patch Set 11:
(17 comments)
File src/mainboard/hp/hp_15_notebook_pc/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/c0ee589c_56fde4ff PS11, Line 15: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, 0xff, 0x04, 0x00, 0x00, 0x12, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/b9372e06_f8b7d513 PS11, Line 16: /* 10 */ 0x01, 0x1b, 0x33, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x04, 0x03, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/156dcdf6_6e1431a3 PS11, Line 17: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/49f12b30_be956b6b PS11, Line 18: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/6ce3e3f8_3aae985f PS11, Line 19: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/efbecca4_c9d61285 PS11, Line 20: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/5cac689e_60e0084c PS11, Line 21: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/ebdfd6ed_fb484d05 PS11, Line 22: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/87b0121b_735698d0 PS11, Line 23: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/ede9421b_c0df2afc PS11, Line 24: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/7a6cd67b_755f6d33 PS11, Line 25: /* a0 */ 0x00, 0x04, 0x00, 0x86, 0xc1, 0x00, 0x00, 0x61, 0x63, 0x00, 0x00, 0x08, 0x64, 0x1a, 0x00, 0xf0, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/d02905ee_2173fdae PS11, Line 26: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x32, 0x02, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/7f202e82_b0729537 PS11, Line 27: /* c0 */ 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/0732cf3f_3db47cd9 PS11, Line 28: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/c8d69a79_361ccecd PS11, Line 29: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/37585b87_056ae4f7 PS11, Line 30: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117642): https://review.coreboot.org/c/coreboot/+/52475/comment/41d31baf_2bf9804a PS11, Line 35: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('