[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: Do dramc software impedance calibration

[Xi Chen (Code Review)]

Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44704 )

Change subject: soc/mediatek/mt8192: Do dramc software impedance calibration
......................................................................

Patch Set 45:

(4 comments)

https://review.coreboot.org/c/coreboot/+/44704/45/src/soc/mediatek/mt8192/dr... 
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:

https://review.coreboot.org/c/coreboot/+/44704/45/src/soc/mediatek/mt8192/dr... 
PS45, Line 7:
> Extra indent

Ack

https://review.coreboot.org/c/coreboot/+/44704/45/src/soc/mediatek/mt8192/dr... 
PS45, Line 14: u8 vref_tmp = 0;
             : 	vref_tmp = imp_vref_sel[odt][drv_type];
> Can be combined into one line.

Ack

https://review.coreboot.org/c/coreboot/+/44704/45/src/soc/mediatek/mt8192/dr... 
PS45, Line 66: OK
> Either "done" or "passed"

Ack

https://review.coreboot.org/c/coreboot/+/44704/45/src/soc/mediatek/mt8192/dr... 
PS45, Line 73: FAIL
> failed

Ack