
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33098 ) Change subject: soc/intel: Replace UART_BASE() and friends with a Kconfig ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/33098/1/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig: https://review.coreboot.org/#/c/33098/1/src/soc/intel/cannonlake/Kconfig@228 PS1, Line 228: default 0xfe032000
increment with CONFIG_UART_FOR_CONSOLE? otherwise only UART0 would be supported. AIUI, our whole infrastructure only supports a single console UART. Any UART_FOR_CONSOLE can use this address. I don't see why we'd need different addresses for different UARTs.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28e1d98aa37a6acb57b98b8882fc4fa131d5d309 Gerrit-Change-Number: 33098 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Thu, 30 May 2019 15:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: comment