Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42040 )
Change subject: tigerlake: add unique acpi device ids for dptf
......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee...
File src/mainboard/google/volteer/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/42040/5/src/mainboard/google/voltee...
PS5, Line 60: Tigerlake
Tiger Lake
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp...
File src/soc/intel/tigerlake/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp...
PS5, Line 3: Tigerlake
Tiger Lake
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp...
PS5, Line 5:
space, not tab
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp...
PS5, Line 7:
space, not tab
https://review.coreboot.org/c/coreboot/+/42040/5/src/soc/intel/tigerlake/acp...
PS5, Line 9:
space, not tab
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dbb812c0fc0f5084c98cf2752ce7ddce8e4d50e
Gerrit-Change-Number: 42040
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 16 Jun 2020 20:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment