Erin Lo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31516 )
Change subject: google/kukui: boot up sspm ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: Load sspm firmware form cbfs and bring up it.
bring it up
I modify to "enable"
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: cbfs
CBFS
Done
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: form
from
Done
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: sspm
SSPM
Done
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@9 PS1, Line 9: bring up it
enables SSPM
Done
https://review.coreboot.org/#/c/31516/1//COMMIT_MSG@13 PS1, Line 13: Boots correctly on Kukui.
How do you verify that SSPM firmware was loaded and works?
Done
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 44: unsigned char buf[BUF_SIZE];
Can you map the area as cacheable? That might prevent that problem because the cache will combine wr […]
The area can't set as cacheable. We don't compress it now. I have move it to src/soc/mediatek/mt8183/sspm.c and use cbfs_boot_map_with_leak(). But it seems the loaded contents are wrong.
https://review.coreboot.org/#/c/31516/1/src/mainboard/google/kukui/mainboard... PS1, Line 48: "sspm"
The point is to declare a 'const char*' / macro for the filename.
Done
https://review.coreboot.org/#/c/31516/2/src/soc/mediatek/mt8183/sspm.c File src/soc/mediatek/mt8183/sspm.c:
https://review.coreboot.org/#/c/31516/2/src/soc/mediatek/mt8183/sspm.c@26 PS2, Line 26: * before we release the reset pin.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/31516/2/src/soc/mediatek/mt8183/sspm.c@27 PS2, Line 27: */
code indent should use tabs where possible
Done