Attention is currently required from: Felix Singer, Jamie Ryu, Wonkyu Kim, Ethan Tsao, Paul Menzel, Kapil Porwal, Angel Pons, Eric Lai, Raj Astekar, Ravishankar Sarawadi.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62772 )
Change subject: soc/intel/mtl: Do initial Meteor Lake SoC commit till bootblock
......................................................................
Patch Set 27:
(2 comments)
File src/soc/intel/meteorlake/bootblock/ioe_die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-149192):
https://review.coreboot.org/c/coreboot/+/62772/comment/ffbe2266_7ca958ba
PS27, Line 8: ioe_p2sb_enable_bar();
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-149192):
https://review.coreboot.org/c/coreboot/+/62772/comment/68a548b0_84b99f59
PS27, Line 8: ioe_p2sb_enable_bar();
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26479fcc3a3f9c6f8ebf5f198ab0809f0b4a2cc4
Gerrit-Change-Number: 62772
Gerrit-PatchSet: 27
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ethan Tsao
ethan.tsao@intel.corp-partner.google.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Comment-Date: Mon, 23 May 2022 07:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment