22 Dec
2019
22 Dec
'19
7:30 p.m.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37859 )
Change subject: mainboard/google/puff: Configure HDA registers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37859/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37859/2/src/mainboard/google/hatch/... PS2, Line 71: Intel HDA Can you be a bit more descriptive what you are overriding for puff and why? See the baseboard for a pretty good example comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9495261201ca256cdb35352338c0b3a82a50196
Gerrit-Change-Number: 37859
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz djkurtz@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Dec 2019 03:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment