Yuchen Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46395 )
Change subject: soc/mediatek/mt8192: add rtc MT6359P driver ......................................................................
Patch Set 39:
(9 comments)
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/in... PS38, Line 101: RTC_GP_OSC32_CON = 2U << 13, /* Keep RG_EOSC_RSV[0] to low for lower leakage current hw design change */
line over 96 characters
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/in... PS38, Line 106: OSC32CON_ANALOG_SETTING = RTC_GP_OSC32_CON | RTC_EOSC32_CHOP_EN | RTC_EOSC32_VCT_EN |\
Avoid unnecessary line continuations
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/in... PS38, Line 107: RTC_GPS_CKOUT_EN | RTC_EMBCK_SEL_OPTION | RTC_EMB_K_EOSC32_MODE
line over 96 characters
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... File src/soc/mediatek/mt8192/rtc.c:
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... PS38, Line 178: if (middle == left) {
braces {} are not necessary for single statement blocks
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... PS38, Line 183: if (val >= RTC_FQMTR_LOW_BASE && val <= RTC_FQMTR_HIGH_BASE) {
braces {} are not necessary for single statement blocks
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... PS38, Line 186: if (val > RTC_FQMTR_HIGH_BASE) {
braces {} are not necessary for any arm of this statement
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... PS38, Line 189: else {
else should follow close brace '}'
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... PS38, Line 304: rtc_write(RTC_BBPU, (bbpu | RTC_BBPU_KEY | RTC_BBPU_RESET_ALARM | RTC_BBPU_RESET_SPAR) & (~RTC_BBPU_SPAR_SW));
line over 96 characters
done
https://review.coreboot.org/c/coreboot/+/46395/38/src/soc/mediatek/mt8192/rt... PS38, Line 370: rtc_write(RTC_AL_YEA, (year | RTC_K_EOSC_RSV_0) & (~RTC_K_EOSC_RSV_1) & (~RTC_K_EOSC_RSV_2));
line over 96 characters
done