build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42626 )
Change subject: Merge Haswell and Broadwell files
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42626/3/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/northbridge_common.c:
https://review.coreboot.org/c/coreboot/+/42626/3/src/northbridge/intel/haswe...
PS3, Line 211: for (i = 0; i < NUM_MAP_ENTRIES; i++) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42626
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e8efc465ebe44ea9b1baaca2a317a29eb9506d
Gerrit-Change-Number: 42626
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 20 Jun 2020 23:49:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment