Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42343 )
Change subject: soc/qualcomm/sc7180/qupv3_config.c: Add missing <string.h> ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42343/1/src/soc/qualcomm/sc7180/qup... File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/42343/1/src/soc/qualcomm/sc7180/qup... PS1, Line 3: #include <commonlib/bsd/cbfs_serialized.h> I agree that the header situation here could use fixing, but this should be <cbfs.h> instead if anything. (And if you're adding it here, can you please also remove it from <soc/qupv3_config.h> where it is not really needed?)