Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32708 )
Change subject: mb/gigabyte/ga-b75m-d3{h,v}: Switch to variant setup
......................................................................
Patch Set 5:
I don't think either of these boards (or any 7 series Gigabyte board in general) shipped with the TPM included. There is a TPM header on the board, though. Should we keep this enabled for boards with header?
Then you'd also need the respective devicetree entry. I would
prefer to have as little changes as possible in this commit,
though, to keep it reviewable. You can still align the boards
further in follow-up commits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia175207a2568aefe1aa9bd8d4d990de6a26f1657
Gerrit-Change-Number: 32708
Gerrit-PatchSet: 5
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 11 May 2019 16:04:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment