Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40539 )
Change subject: tests: Add device/i2c-test test case
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40539/3/tests/device/i2c-test.c
File tests/device/i2c-test.c:
https://review.coreboot.org/c/coreboot/+/40539/3/tests/device/i2c-test.c@48
PS3, Line 48: int __wrap_platform_i2c_transfer(unsigned int bus, struct i2c_msg *segments,
I don't think I agree with this, at least not as a general rule. […]
OK, then I guess this one is OK for here. But we should probably look at making a future example where two separate tests share one mock, to demonstrate the concept.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2eeb565aacc724ae3b9f5c76ef4b98ef695416d6
Gerrit-Change-Number: 40539
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Apr 2020 02:50:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment