Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c@1453
PS2, Line 1453: " adl - Alder Lake\n"
: " aplk - Apollo Lake\n"
: " cnl - Cannon Lake\n"
: " glk - Gemini Lake\n"
: " icl - Ice Lake\n"
: " jsl - Jasper Lake\n"
: " sklkbl - Skylake/Kaby Lake\n"
: " tgl - Tiger Lake\n"
: " -S | --setpchstrap Write a PCH strap\n"
minor nit: would be nice to line these up as well: […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c9106051f4daf592d2467ebf79f9ddb037011dc
Gerrit-Change-Number: 44809
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Thu, 27 Aug 2020 07:11:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment