Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33534 )
Change subject: vboot: relocate code to log and clear recovery mode switch ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33534/1/src/security/vboot/vboot_logic.c File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/#/c/33534/1/src/security/vboot/vboot_logic.c@285 PS1, Line 285: vboot_log_and_clear_recovery_mode_switch
Just thinking out loud: This should have the same effect as before because - […]
Two questions about saving recovery reason to VBNV:
(1) In vboot_prepare, vboot_save_recovery_reason_vbnv is only called in the verification_should_run() clause, and not in the verstage_should_load() clause. Why is that?
(2) Depending on the answer to (1), should we be calling vboot_save_recovery_reason_vbnv from verstage_main instead?