Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32663 )
Change subject: src/amd/stoneyridge: Move alink source to common ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32663/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32663/4//COMMIT_MSG@11 PS4, Line 11: however more modern APUs define only ABCFG in : the BKDGs.
How do you ensure that common code does not end up accessing register spaces which are not defined?
That's not ensured. However these are really only helper functions, i.e. they don't have any knowledge of what to program, register definitions, etc. It's a bit like asking how can read32() ensure it's not being used at a location that doesn't exist.
OTOH, this code's no longer called -- any real need-to-know for the hardware seems to have been buried in AGESA for a while now. I was 6 vs. 0.5 dozen on simply removing it from stoneyridge. And stoneyridge doesn't select the Kconfig symbol.
https://review.coreboot.org/#/c/32663/4/src/soc/amd/common/block/include/amd... File src/soc/amd/common/block/include/amdblocks/alink.h:
https://review.coreboot.org/#/c/32663/4/src/soc/amd/common/block/include/amd... PS4, Line 22: +
nit: space around +.
Ew right. I didn't even hardly look at the file.