Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35606 )
Change subject: util/mb/google/hatch: script can take optional bug parameter ......................................................................
util/mb/google/hatch: script can take optional bug parameter
When creating a new variant, adding a bug parameter after the name of the variant will populate the BUG= field in the commit message. If the paramter is not present, then BUG=None.
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3 --- M util/mainboard/google/hatch/create_coreboot_variant.sh 1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35606/1
diff --git a/util/mainboard/google/hatch/create_coreboot_variant.sh b/util/mainboard/google/hatch/create_coreboot_variant.sh index c6cbb49..065fb6d 100755 --- a/util/mainboard/google/hatch/create_coreboot_variant.sh +++ b/util/mainboard/google/hatch/create_coreboot_variant.sh @@ -13,9 +13,9 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details.
-if [[ "$#" -ne 1 ]]; then - echo "Usage: $0 variant_name" - echo "e.g. $0 kohaku" +if [[ "$#" -lt 1 ]]; then + echo "Usage: $0 variant_name [bug_number]" + echo "e.g. $0 kohaku b:140261109" echo "Adds a new variant of Hatch to Kconfig and Kconfig.name, creates the" echo "skeleton files for acpi, ec, and gpio, copies the makefile for" echo "SPD sources, and sets up a basic overridetree" @@ -32,6 +32,9 @@ VARIANT="${1,,}" VARIANT_UPPER="${VARIANT^^}"
+# Assign BUG= text, or "None" if that parameter wasn't specified. +BUG=${2:-None} + # This script and the templates live in util/mainboard/google/hatch # We need to create files in src/mainboard/google/hatch pushd "${BASH_SOURCE%/*}" || exit 1 @@ -69,7 +72,7 @@ # Now commit the files. git commit -sm "${BASE}: Create ${VARIANT} variant
-BUG=none +BUG=${BUG} TEST=util/abuild/abuild -p none -t google/${BASE} -x -a make sure the build includes GOOGLE_${VARIANT_UPPER}"