Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... PS8, Line 9: register "gpu_panel_port_select" = "0" # LVDS
This should probably go to the variant overridetree
It also applies to x230.
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 4: docking_supported
Why is it removed?
It does not present in the original devicetree.cb of x230, but presents in that of t430s. I do believe that it could be added here.
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/board_info.txt:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: baseboard
I don't think you meant to add "baseboard" here
Done
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: # Disable DisplayPort Hotplug : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4"
Did you try dropping these completely?
No. These values are obtained via autoport, which means they are set so with vendor firmware, too.