[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Fix overlapping memory address used for early GS...

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47643 )

Change subject: soc/intel/tigerlake: Fix overlapping memory address used for early GSPI2 and UART bars
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47643/1/src/soc/intel/tigerlake/Kco... 
File src/soc/intel/tigerlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/47643/1/src/soc/intel/tigerlake/Kco... 
PS1, Line 169: 0xfe03e000
> > I don't understand why we have the BAR defined in two different places: https://review.coreboot. […]

Agree that we need to use single definition.
How about using config value in iomap.h rather than defining again with constant value?
I mean change like below.
#define UART_BASE_0_ADDRESS    CONFIG_CONSOLE_UART_BASE_ADDRESS
Then we can just correct value for Kconfig value.