Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39430 )
Change subject: edid_fill_fb: Add row_alignment argument ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39430/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39430/7//COMMIT_MSG@11 PS7, Line 11: to bits_per_pixel/8.
Please re-flow for 72/75 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/39430/6/src/lib/edid_fill_fb.c File src/lib/edid_fill_fb.c:
https://review.coreboot.org/c/coreboot/+/39430/6/src/lib/edid_fill_fb.c@81 PS6, Line 81: bytes_per_line = ALIGN_UP(x_resolution * bits_per_pixel / 8, row_alignment);
Like I mentioned in CB:39002 I think this is a problem. […]
Added an check to compare bits_per_pixel and the accumulated mask_sizes. If it's not equal an error is printed and the accumulated mask_size is used. Note: This break the RGB888 pixel format, but I guess that's OK for now as 24bpp in coreboot actually means XRGB8.