Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
ot_song fan has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email )
Change subject: soc/mediatek/mt8196: Add srclken_rc drivers ......................................................................
Patch Set 5:
(5 comments)
File src/soc/mediatek/mt8196/include/soc/srclken_rc.h:
https://review.coreboot.org/c/coreboot/+/85842/comment/5ef5a6c3_fb44df63?usp... : PS4, Line 86:
Add `check_member(mtk_rc_regs, rc_spi_sta_0, 0x10c);`.
Done
File src/soc/mediatek/mt8196/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/85842/comment/0fffad7d_aeccd29b?usp... : PS1, Line 265: code flow ASSERT already
Do you mean the `assert(id < MAX_CHN_NUM)` call? How's that related to the rc_mxx_req_sta_0 register […]
The id will be used to set the rc_mxx_srclken_cfg, and the rc_mxx_req_sta_0 will related to the rc_mxx_srclken_cfg.
File src/soc/mediatek/mt8196/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/85842/comment/7d8dcf99_e536354a?usp... : PS4, Line 474: REQ_TO_SPMI_P_MASK_SHFT
`REQ_TO_SPMI_P_SUBSYS` is already a 32-bit value, do we still need `REQ_TO_SPMI_P_MASK_SHFT`? If you […]
Done
https://review.coreboot.org/c/coreboot/+/85842/comment/df8afb91_5b6f5061?usp... : PS4, Line 477: write32
Can we use `WRITE32_BITFIELDS`?
Done
https://review.coreboot.org/c/coreboot/+/85842/comment/e3c2f597_6d5088ce?usp... : PS4, Line 527: 0xA
Done