Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32519 )
Change subject: mb/google/sarien: Turn off camera power when s0ix
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32519/4/src/soc/intel/cannonlake/acpi/lpit.a...
File src/soc/intel/cannonlake/acpi/lpit.asl:
https://review.coreboot.org/#/c/32519/4/src/soc/intel/cannonlake/acpi/lpit.a...
PS4, Line 67: If (CondRefOf (_SB.MS0X)) {
: _SB.MS0X(1)
: }
Add a comment to describe that's the s0ix hooks at motherboard level, or make the MS0X looks more clear. On the other thought similar thing can be applied to EC0.S0IX as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a9b7ec1e95cc9931d8d5f2dc1254805c9d0ffed
Gerrit-Change-Number: 32519
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 May 2019 17:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment