[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/systemagent: Add SOC_INTEL_COMMON_BLOCK_SA_VERSION_2...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38456 )

Change subject: soc/intel/common/systemagent: Add SOC_INTEL_COMMON_BLOCK_SA_VERSION_2 till 5
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38456/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38456/4//COMMIT_MSG@7 
PS4, Line 7: 2 till 5
> The obvious question is: What does "SA version 1" correspond to? I guess it would correspond to HSW/ […]

I was trying to avoid version_1 and trying to convey that SOC_INTEL_COMMON_BLOCK_SA is the base code for all those SoC, starting from APL till latest TGL. Anything changes from APL till now, divided into version.

But i like your way, converting those bits into Kconfig and assign those Kconfig from respected SOC so we can fill in correct value without bothering about version.

Let me modify this code