Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40538 )
Change subject: tests: Add lib/string-test test case
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40538/4/tests/lib/string-test.c
File tests/lib/string-test.c:
https://review.coreboot.org/c/coreboot/+/40538/4/tests/lib/string-test.c@40
PS4, Line 40: /* There is a more suitable Cmocka's function 'assert_string_equal()', but it
The two allowed coreboot comment styles are
/* short form, note the
lack of an asterisk
on the continuation lines. */
/*
* Long form with
* a blank line both
* above and below.
*/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40538
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf5554d1e99a393721a66bdd35af0122c2e412c4
Gerrit-Change-Number: 40538
Gerrit-PatchSet: 4
Gerrit-Owner: Name of user not set #1002873
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 27 Apr 2020 20:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment