Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46634 )
Change subject: cpu/intel/common: Fix regression ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46634/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46634/1//COMMIT_MSG@9 PS1, Line 9: Fix the logic introduced in CB:46276 : "cpu/intel/common: only lock AES-NI when supported" : which needs to be negated. Nit: I suggest the following commit message:
cpu/intel/common: Fix boot failure
Commit 469a99b (cpu/intel/common: only lock AES-NI when supported) forgot to negate a check, so the AES-NI MSR is locked only when the CPU does *not* support it, which causes a GP fault. Invert it.