[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/dedede/var/drawcia: Fix variant devicetree update

[Robert Chen (Code Review)]

Robert Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84952?usp=email )

Change subject: mb/google/dedede/var/drawcia: Fix variant devicetree update
......................................................................

mb/google/dedede/var/drawcia: Fix variant devicetree update

External VR update should be execute after 0xb board version.

BUG=None
BRANCH=firmware-dedede-13606.B
TEST=emerge-dedede coreboot chromeos-bootimage

Change-Id: I4a1ca49b9681d9a75194016353997c91eb49d198
---
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
1 file changed, 20 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/84952/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/ramstage.c b/src/mainboard/google/dedede/variants/drawcia/ramstage.c
index aed160e..e9ce712 100644
--- a/src/mainboard/google/dedede/variants/drawcia/ramstage.c
+++ b/src/mainboard/google/dedede/variants/drawcia/ramstage.c
@@ -9,26 +9,37 @@

static void ext_vr_update(void)
 {
+	uint32_t board_version = board_id();
    struct soc_intel_jasperlake_config *cfg = config_of_soc();
+
+	 /* Power IC remove from board version 0xc */
+        if (board_version < 0xc)
+                return;
+
    if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT)))
    	cfg->disable_external_bypass_vr = 1;
 }

-void variant_devtree_update(void)
+static void update_lte_device(void)
 {
    uint32_t board_version = board_id();
-	struct device *lte_usb2 = DEV_PTR(lte_usb2);
-	struct drivers_usb_acpi_config *config;
-	struct acpi_gpio lte_reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0);
+        struct device *lte_usb2 = DEV_PTR(lte_usb2);
+        struct drivers_usb_acpi_config *config;
+        struct acpi_gpio lte_reset_gpio = ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H0);

/* board version 9 is drawper EVT */
-	if (board_version > 9)
-		return;
+        if (board_version > 9)
+                return;

-	if (lte_usb2 == NULL)
-		return;
+        if (lte_usb2 == NULL)
+                return;

config = config_of(lte_usb2);
-	config->reset_gpio = lte_reset_gpio;
+        config->reset_gpio = lte_reset_gpio;
+}
+
+void variant_devtree_update(void)
+{
+	update_lte_device();
    ext_vr_update();
 }