Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59373 )
Change subject: mb/google/volteer/var/chronicler: set DdrMemoryDown enable ......................................................................
mb/google/volteer/var/chronicler: set DdrMemoryDown enable
as doc #632048, there is a fix in MRC for this sighting but DdrMemoryDown need to be set to 1.
BUG=b:192478111 BRANCH=volteer TEST=FW_NAME=chronicler emerge-volteer coreboot chromeos-bootimage Signed-off-by: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Change-Id: If7ead2d0bb2955a4f1b81d012ee2e2518b2a82e4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59373 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/chronicler/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sheng-Liang Pan: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/chronicler/memory.c b/src/mainboard/google/volteer/variants/chronicler/memory.c index 8ec6996..8c67a2d 100644 --- a/src/mainboard/google/volteer/variants/chronicler/memory.c +++ b/src/mainboard/google/volteer/variants/chronicler/memory.c @@ -24,3 +24,9 @@
return gpio_base2_value(spd_gpios, ARRAY_SIZE(spd_gpios)); } + +void memcfg_variant_init(FSPM_UPD *mupd) +{ + FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig; + mem_cfg->DdrMemoryDown = 1; +}