Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45812 )
Change subject: amdfwtool: Use a variable to get the return value of write
......................................................................
Patch Set 1: Code-Review+1
please move this patch before "amdfwtool: Clean up the Makefile of amdfwtool", so that the issue this patch fixes is already fixed when the makefile change adds some more warning and error compiler switches. the patch itself is good
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45812
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8099b856ccb751dc380d0e95f5fe319cc3e2c6cc
Gerrit-Change-Number: 45812
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 15:55:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment