Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36451 )
Change subject: mb/intel/saddlebrook: Enable Chipset_lockdown coreboot config
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36451/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36451/1//COMMIT_MSG@12
PS1, Line 12: verified MRC is restored on warm, cold,
: resume boot path's
What does that have to do with the lockdown?
Lockdown can affect everything. Especially in the presence of undocumented
blobs. For instance, if locking happens too early, a register write may fail
silently. In this case, I'd assume that the MRC cache can't be written if
some flash locking is out of sync.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36451
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia324c118b0c8e72b66a757dee5be43ba79abbeab
Gerrit-Change-Number: 36451
Gerrit-PatchSet: 1
Gerrit-Owner: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Teo Boon Tiong
boon.tiong.teo@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Oct 2019 22:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment