Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34625 )
Change subject: src/arch/x86/acpi: Constify struct device instances ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/acpi.c@948 PS1, Line 948: unsigned long acpi_write_dbg2_pci_uart(acpi_rsdp_t *rsdp, unsigned long current,
align with (
That would push it over 80 chars, will have to then split in 3 lines, did not look good. Can we keep as is?
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/include/arch/a... File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/c/coreboot/+/34625/1/src/arch/x86/include/arch/a... PS1, Line 904: const struct device *dev, uint8_t access_size);
align with (
That would push it over 80 chars, will have to then split in 3 lines, did not look good. Can we keep as is?