Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: [RFC] Add new board configuration entry to coreboot tables ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46605/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46605/1//COMMIT_MSG@10 PS1, Line 10: possibly deprecating the three separate "strapping ID" tables with : which it is slightly redundant with. Let's do that deprecation right away in the same patch?
https://review.coreboot.org/c/coreboot/+/46605/1/src/include/fw_config.h File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/46605/1/src/include/fw_config.h@11 PS1, Line 11: #define DEFAULT_FW_CONFIG (uint64_t)0 Can we please use the existing UNDEFINED_STRAPPING_ID (~0, or now better ~(uint64_t)0) for this? For CBI-based fw_config this doesn't matter, but if other boards later use strapping-based fw_config then 0 will be a valid value that they may want to use for a real config (since there's often only very few values to use anyway). ~0 is usually safe because nobody designs a strapping with all 64 pins.