John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46048 )
Change subject: mb/google/zork/var/vilboz: update dptc stapm time
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/46048/4/src/mainboard/google/zork/v...
PS4, Line 4:
: /* Enable DPTC support */
: #define EC_ENABLE_AMD_DPTC_SUPPORT
If this change is not only for tablet mode. I think that it wouldn't add this define.
We don't switch tablet and clamshell mode from our thermal team confirm.
I will change this patch again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61d9e00a9d098ad9699b8cf89e70d11de2b95ffd
Gerrit-Change-Number: 46048
Gerrit-PatchSet: 5
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 14 Oct 2020 09:39:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-MessageType: comment