Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )
Change subject: util/amdfwtool: Deal with psp position in flash offset directly ......................................................................
Patch Set 2:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164177): https://review.coreboot.org/c/coreboot/+/69852/comment/75717f0b_5d605fd4 PS2, Line 2328: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164177): https://review.coreboot.org/c/coreboot/+/69852/comment/3b022495_aca5eabf PS2, Line 2329: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164177): https://review.coreboot.org/c/coreboot/+/69852/comment/947c43f3_9e2e5cb7 PS2, Line 2330: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164177): https://review.coreboot.org/c/coreboot/+/69852/comment/99df1de8_ea3da53f PS2, Line 2331: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164177): https://review.coreboot.org/c/coreboot/+/69852/comment/bfb31a55_ee070fcb PS2, Line 2332: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164177): https://review.coreboot.org/c/coreboot/+/69852/comment/cd149461_4a16cbf2 PS2, Line 2333: case 0x20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment