Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41898 )
Change subject: soc/amd/picasso: solve MTRRs only from 4GiB and below
......................................................................
Patch Set 4:
It sounded like there was something goofed with yesterday's CQ ordering and many people were seeing problems. So hopefully if you give it another try it'll be OK. I did a repo sync Saturday morning and checked it on Mandolin. I rebased these 3 changes on top of 524962 and cherry-picked CB:33772. I'm not seeing the problems you're reporting. Also FWIW I verified the MTRRs are unmodified during the two FSP calls.
Ok, I'll retry that later today with a fresh FSP repo checkout. Only had 1 new MTRR related change in my FSP repo checkout when I built that yesterday; might be the cause of the issues
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8358b614682f6a97278f3a60b5ada5e607965af
Gerrit-Change-Number: 41898
Gerrit-PatchSet: 4
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 06 Jun 2020 17:06:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment