30 Jun
2020
30 Jun
'20
4:48 p.m.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42495 )
Change subject: mb/ocp/deltalake: Configure IPMI FRB2 watchdog timer via VPD variables in romstage ......................................................................
Patch Set 11:
(1 comment)
LGTM
https://review.coreboot.org/c/coreboot/+/42495/11/src/mainboard/ocp/deltalak... File src/mainboard/ocp/deltalake/ipmi.c:
https://review.coreboot.org/c/coreboot/+/42495/11/src/mainboard/ocp/deltalak... PS11, Line 12: #define FRB2_TIMER "FRB2_TIMER" For VPD key names, let's use lower characters by default, unless the VPD key is for FSP UPD variable, in such case FSP UPD variable name is used as-is.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ce3bdc24a41d27eb1877655b3148ba02f7f5497
Gerrit-Change-Number: 42495
Gerrit-PatchSet: 11
Gerrit-Owner: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 16:48:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment